Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DurableTask] Creation of Durable Task CLI Extension #7942

Merged
merged 19 commits into from
Sep 18, 2024
Merged

[DurableTask] Creation of Durable Task CLI Extension #7942

merged 19 commits into from
Sep 18, 2024

Conversation

RyanLettieri
Copy link
Contributor

@RyanLettieri RyanLettieri commented Sep 2, 2024 •
edited
Loading

This is a PR for implementing the durabletask service extension into the azure python cli. It currently contains the following commands for both namespaces and taskhubs:

  1. Create
  2. List
  3. Show
  4. Delete

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • [ x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [ x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [x ] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd azure-client-tools-bot-prd
Copy link

Hi @RyanLettieri,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd azure-client-tools-bot-prd
Copy link

Hi @RyanLettieri,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 2, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024 •
edited
Loading

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 2, 2024
@yonzhan yonzhan requested a review from jsntcy September 2, 2024 23:11
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 6, 2024
@RyanLettieri RyanLettieri changed the title Creation of DTS CLI Extension Creation of Durable Task CLI Extension Sep 6, 2024
@RyanLettieri RyanLettieri marked this pull request as ready for review September 6, 2024 15:50
@github-actions github-actions bot added release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. and removed release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. labels Sep 10, 2024
@RyanLettieri RyanLettieri changed the title Creation of Durable Task CLI Extension [DurableTask] Creation of Durable Task CLI Extension Sep 11, 2024
jsntcy
jsntcy reviewed Sep 12, 2024
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@RyanLettieri
Initial push for dts CLI. Still has hardcoded stuff
af58089 
Signed-off-by: Ryan Lettieri <[email protected]>
@RyanLettieri
More changes to allow for namespace create and list to have appropria…
8e87300 
…te params

Signed-off-by: Ryan Lettieri <[email protected]>
@RyanLettieri
Linting and styling
0ffd553 
Signed-off-by: Ryan Lettieri <[email protected]>
@RyanLettieri
Removing max cli version constraint
c9f109f 
Signed-off-by: Ryan Lettieri <[email protected]>
@RyanLettieri
Adding in additional commands, help, and removing test
7c3a939 
Signed-off-by: Ryan Lettieri <[email protected]>
@RyanLettieri
More cleanup
1c2caf1 
Signed-off-by: Ryan Lettieri <[email protected]>
@RyanLettieri
Fixing ids on list and constructor args
c2db05d 
Signed-off-by: Ryan Lettieri <[email protected]>
@RyanLettieri
Adressing CI errors for preview and service name
55d5318 
Signed-off-by: Ryan Lettieri <[email protected]>
@RyanLettieri
Updating version
61f8de3 
Signed-off-by: Ryan Lettieri <[email protected]>
@RyanLettieri
Renaming durabletask to durabletask-preview
332addd 
Signed-off-by: Ryan Lettieri <[email protected]>
@RyanLettieri
More name change fixes to add preview
5ae0b40 
Signed-off-by: Ryan Lettieri <[email protected]>
kairu-ms
kairu-ms reviewed Sep 18, 2024
View reviewed changes
src/durabletask/README.md Outdated Show resolved Hide resolved
kairu-ms
kairu-ms reviewed Sep 18, 2024
View reviewed changes
src/durabletask/azext_durabletask/tests/latest/test_durabletask.py

class DurabletaskScenario(ScenarioTest):
def test_help(self):
pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for the commands

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since our service is still in private preview and being finalized/stabilized, I don't believe we should have testing at this time due to the possibility of a failure occurring on the underlying service. Furthermore, subscriptions must be first registered and then approved for this service.

@kairu-ms kairu-ms merged commit 5c42478 into Azure:main Sep 18, 2024
20 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ durabletask ] : https://dev.azure.com/azclitools/release/_build/results?buildId=190332&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsntcy jsntcy jsntcy left review comments

@kairu-ms kairu-ms kairu-ms approved these changes

@berndverst berndverst berndverst approved these changes

Assignees

@kairu-ms kairu-ms

Labels
None yet
Projects
None yet
Milestone
September 2024 (2024-10-08)
Development

Successfully merging this pull request may close these issues.
6 participants
@RyanLettieri @yonzhan @azclibot @berndverst @jsntcy @kairu-ms